Skip to content

chore: use price-api to fetch exchange rates in currencyRatesController #6863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

chore: use price-api to fetch exchange rates in currencyRatesController #6863

wants to merge 7 commits into from

Conversation

sahar-fehri
Copy link
Contributor

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@sahar-fehri sahar-fehri changed the title chore: use price-api to fetch exchange rates and fallback to crypto-c… chore: use price-api to fetch exchange rates in currencyRatesController Oct 16, 2025
@sahar-fehri sahar-fehri force-pushed the fix/use-price-api-exchange-rates-instead-of-cryptocompare-in-currencyRatesController branch from 748a952 to a7ce511 Compare October 16, 2025 16:06
@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

2 similar comments
@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/account-tree-controller": "1.5.0-preview-870f4d81",
  "@metamask-previews/accounts-controller": "33.1.1-preview-870f4d81",
  "@metamask-previews/address-book-controller": "6.2.0-preview-870f4d81",
  "@metamask-previews/announcement-controller": "7.1.0-preview-870f4d81",
  "@metamask-previews/app-metadata-controller": "1.1.0-preview-870f4d81",
  "@metamask-previews/approval-controller": "7.2.0-preview-870f4d81",
  "@metamask-previews/assets-controllers": "81.0.1-preview-870f4d81",
  "@metamask-previews/base-controller": "8.4.1-preview-870f4d81",
  "@metamask-previews/bridge-controller": "52.0.0-preview-870f4d81",
  "@metamask-previews/bridge-status-controller": "51.0.0-preview-870f4d81",
  "@metamask-previews/build-utils": "3.0.4-preview-870f4d81",
  "@metamask-previews/chain-agnostic-permission": "1.2.0-preview-870f4d81",
  "@metamask-previews/composable-controller": "11.1.0-preview-870f4d81",
  "@metamask-previews/controller-utils": "11.14.1-preview-870f4d81",
  "@metamask-previews/core-backend": "2.1.0-preview-870f4d81",
  "@metamask-previews/delegation-controller": "0.8.0-preview-870f4d81",
  "@metamask-previews/earn-controller": "8.0.1-preview-870f4d81",
  "@metamask-previews/eip-5792-middleware": "1.2.3-preview-870f4d81",
  "@metamask-previews/eip1193-permission-middleware": "1.0.1-preview-870f4d81",
  "@metamask-previews/ens-controller": "17.1.0-preview-870f4d81",
  "@metamask-previews/error-reporting-service": "2.2.1-preview-870f4d81",
  "@metamask-previews/eth-block-tracker": "14.0.0-preview-870f4d81",
  "@metamask-previews/eth-json-rpc-middleware": "21.0.0-preview-870f4d81",
  "@metamask-previews/eth-json-rpc-provider": "5.0.1-preview-870f4d81",
  "@metamask-previews/foundryup": "1.0.1-preview-870f4d81",
  "@metamask-previews/gas-fee-controller": "24.1.0-preview-870f4d81",
  "@metamask-previews/gator-permissions-controller": "0.2.1-preview-870f4d81",
  "@metamask-previews/json-rpc-engine": "10.1.1-preview-870f4d81",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-870f4d81",
  "@metamask-previews/keyring-controller": "23.1.1-preview-870f4d81",
  "@metamask-previews/logging-controller": "6.1.0-preview-870f4d81",
  "@metamask-previews/message-manager": "13.0.1-preview-870f4d81",
  "@metamask-previews/messenger": "0.3.0-preview-870f4d81",
  "@metamask-previews/multichain-account-service": "1.6.1-preview-870f4d81",
  "@metamask-previews/multichain-api-middleware": "1.2.1-preview-870f4d81",
  "@metamask-previews/multichain-network-controller": "1.0.1-preview-870f4d81",
  "@metamask-previews/multichain-transactions-controller": "5.1.0-preview-870f4d81",
  "@metamask-previews/name-controller": "8.1.0-preview-870f4d81",
  "@metamask-previews/network-controller": "24.3.0-preview-870f4d81",
  "@metamask-previews/network-enablement-controller": "2.1.1-preview-870f4d81",
  "@metamask-previews/notification-services-controller": "18.3.0-preview-870f4d81",
  "@metamask-previews/permission-controller": "11.1.0-preview-870f4d81",
  "@metamask-previews/permission-log-controller": "4.1.0-preview-870f4d81",
  "@metamask-previews/phishing-controller": "14.1.2-preview-870f4d81",
  "@metamask-previews/polling-controller": "14.0.1-preview-870f4d81",
  "@metamask-previews/preferences-controller": "20.0.2-preview-870f4d81",
  "@metamask-previews/profile-sync-controller": "25.1.1-preview-870f4d81",
  "@metamask-previews/rate-limit-controller": "6.1.0-preview-870f4d81",
  "@metamask-previews/remote-feature-flag-controller": "1.9.0-preview-870f4d81",
  "@metamask-previews/sample-controllers": "2.0.1-preview-870f4d81",
  "@metamask-previews/seedless-onboarding-controller": "4.1.0-preview-870f4d81",
  "@metamask-previews/selected-network-controller": "24.0.1-preview-870f4d81",
  "@metamask-previews/shield-controller": "0.3.2-preview-870f4d81",
  "@metamask-previews/signature-controller": "34.0.1-preview-870f4d81",
  "@metamask-previews/subscription-controller": "2.0.0-preview-870f4d81",
  "@metamask-previews/token-search-discovery-controller": "3.5.0-preview-870f4d81",
  "@metamask-previews/transaction-controller": "60.9.0-preview-870f4d81",
  "@metamask-previews/user-operation-controller": "39.2.0-preview-870f4d81"
}

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/account-tree-controller": "1.5.0-preview-b3e5b3e7",
  "@metamask-previews/accounts-controller": "33.1.1-preview-b3e5b3e7",
  "@metamask-previews/address-book-controller": "6.2.0-preview-b3e5b3e7",
  "@metamask-previews/announcement-controller": "7.1.0-preview-b3e5b3e7",
  "@metamask-previews/app-metadata-controller": "1.1.0-preview-b3e5b3e7",
  "@metamask-previews/approval-controller": "7.2.0-preview-b3e5b3e7",
  "@metamask-previews/assets-controllers": "81.0.1-preview-b3e5b3e7",
  "@metamask-previews/base-controller": "8.4.1-preview-b3e5b3e7",
  "@metamask-previews/bridge-controller": "52.0.0-preview-b3e5b3e7",
  "@metamask-previews/bridge-status-controller": "51.0.0-preview-b3e5b3e7",
  "@metamask-previews/build-utils": "3.0.4-preview-b3e5b3e7",
  "@metamask-previews/chain-agnostic-permission": "1.2.0-preview-b3e5b3e7",
  "@metamask-previews/composable-controller": "11.1.0-preview-b3e5b3e7",
  "@metamask-previews/controller-utils": "11.14.1-preview-b3e5b3e7",
  "@metamask-previews/core-backend": "2.1.0-preview-b3e5b3e7",
  "@metamask-previews/delegation-controller": "0.8.0-preview-b3e5b3e7",
  "@metamask-previews/earn-controller": "8.0.1-preview-b3e5b3e7",
  "@metamask-previews/eip-5792-middleware": "1.2.3-preview-b3e5b3e7",
  "@metamask-previews/eip1193-permission-middleware": "1.0.1-preview-b3e5b3e7",
  "@metamask-previews/ens-controller": "17.1.0-preview-b3e5b3e7",
  "@metamask-previews/error-reporting-service": "2.2.1-preview-b3e5b3e7",
  "@metamask-previews/eth-block-tracker": "14.0.0-preview-b3e5b3e7",
  "@metamask-previews/eth-json-rpc-middleware": "21.0.0-preview-b3e5b3e7",
  "@metamask-previews/eth-json-rpc-provider": "5.0.1-preview-b3e5b3e7",
  "@metamask-previews/foundryup": "1.0.1-preview-b3e5b3e7",
  "@metamask-previews/gas-fee-controller": "24.1.0-preview-b3e5b3e7",
  "@metamask-previews/gator-permissions-controller": "0.2.1-preview-b3e5b3e7",
  "@metamask-previews/json-rpc-engine": "10.1.1-preview-b3e5b3e7",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-b3e5b3e7",
  "@metamask-previews/keyring-controller": "23.1.1-preview-b3e5b3e7",
  "@metamask-previews/logging-controller": "6.1.0-preview-b3e5b3e7",
  "@metamask-previews/message-manager": "13.0.1-preview-b3e5b3e7",
  "@metamask-previews/messenger": "0.3.0-preview-b3e5b3e7",
  "@metamask-previews/multichain-account-service": "1.6.1-preview-b3e5b3e7",
  "@metamask-previews/multichain-api-middleware": "1.2.1-preview-b3e5b3e7",
  "@metamask-previews/multichain-network-controller": "1.0.1-preview-b3e5b3e7",
  "@metamask-previews/multichain-transactions-controller": "5.1.0-preview-b3e5b3e7",
  "@metamask-previews/name-controller": "8.1.0-preview-b3e5b3e7",
  "@metamask-previews/network-controller": "24.3.0-preview-b3e5b3e7",
  "@metamask-previews/network-enablement-controller": "2.1.1-preview-b3e5b3e7",
  "@metamask-previews/notification-services-controller": "18.3.0-preview-b3e5b3e7",
  "@metamask-previews/permission-controller": "11.1.0-preview-b3e5b3e7",
  "@metamask-previews/permission-log-controller": "4.1.0-preview-b3e5b3e7",
  "@metamask-previews/phishing-controller": "14.1.2-preview-b3e5b3e7",
  "@metamask-previews/polling-controller": "14.0.1-preview-b3e5b3e7",
  "@metamask-previews/preferences-controller": "20.0.2-preview-b3e5b3e7",
  "@metamask-previews/profile-sync-controller": "25.1.1-preview-b3e5b3e7",
  "@metamask-previews/rate-limit-controller": "6.1.0-preview-b3e5b3e7",
  "@metamask-previews/remote-feature-flag-controller": "1.9.0-preview-b3e5b3e7",
  "@metamask-previews/sample-controllers": "2.0.1-preview-b3e5b3e7",
  "@metamask-previews/seedless-onboarding-controller": "4.1.0-preview-b3e5b3e7",
  "@metamask-previews/selected-network-controller": "24.0.1-preview-b3e5b3e7",
  "@metamask-previews/shield-controller": "0.3.2-preview-b3e5b3e7",
  "@metamask-previews/signature-controller": "34.0.1-preview-b3e5b3e7",
  "@metamask-previews/subscription-controller": "2.0.0-preview-b3e5b3e7",
  "@metamask-previews/token-search-discovery-controller": "3.5.0-preview-b3e5b3e7",
  "@metamask-previews/transaction-controller": "60.9.0-preview-b3e5b3e7",
  "@metamask-previews/user-operation-controller": "39.2.0-preview-b3e5b3e7"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sahar-fehri